Patchwork [1/1] image-types: add btrfs as a supported fstype

login
register
mail settings
Submitter Nitin A Kamble
Date Sept. 6, 2011, 9:06 p.m.
Message ID <7318770f8b3b34d4ec29ee592971a5be96e53151.1315343093.git.nitin.a.kamble@intel.com>
Download mbox | patch
Permalink /patch/11091/
State New, archived
Headers show

Comments

Nitin A Kamble - Sept. 6, 2011, 9:06 p.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Joshua Lock - Sept. 6, 2011, 10:38 p.m.
On Tue, 2011-09-06 at 14:06 -0700, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/classes/image_types.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index c24b326..3e303ed 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -141,4 +141,4 @@ IMAGE_DEPENDS_ubi = "mtd-utils-native"
>  IMAGE_DEPENDS_ubifs = "mtd-utils-native"
>  
>  # This variable is available to request which values are suitable for IMAGE_FSTYPES
> -IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz live squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"
> +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz btrfs live squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"

This isn't enough, the variable you've modified is one used only by the
hob UI.

You need to define IMAGE_CMD_btrfs and possibly IMAGE_DEPENDS_btrfs
entries, maybe EXTRA_IMAGE_CMD_btrfs too if required?

Cheers,
Joshua
Anders Darander - Sept. 7, 2011, 7:15 a.m.
* nitin.a.kamble@intel.com <nitin.a.kamble@intel.com> [110906 23:07]:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/classes/image_types.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index c24b326..3e303ed 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -141,4 +141,4 @@ IMAGE_DEPENDS_ubi = "mtd-utils-native"
>  IMAGE_DEPENDS_ubifs = "mtd-utils-native"
>  
>  # This variable is available to request which values are suitable for IMAGE_FSTYPES
> -IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz live squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"
> +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz btrfs live squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"

As Joshua already replied, this isn't enough.
This raises one question, though. Have you successfully built
btrfs-image? If so, I assume that you have more patches locally,
otherwise you should resist submitting patches, unless they're clearly
marked as RFC (request for comments, and thus not to be applied).

Cheers,
Anders
Nitin A Kamble - Sept. 7, 2011, 6:28 p.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Anders Darander
> Sent: Wednesday, September 07, 2011 12:16 AM
> To: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 1/1] image-types: add btrfs as a
> supported fstype
> 
> * nitin.a.kamble@intel.com <nitin.a.kamble@intel.com> [110906 23:07]:
> > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >
> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > ---
> >  meta/classes/image_types.bbclass |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/classes/image_types.bbclass
> b/meta/classes/image_types.bbclass
> > index c24b326..3e303ed 100644
> > --- a/meta/classes/image_types.bbclass
> > +++ b/meta/classes/image_types.bbclass
> > @@ -141,4 +141,4 @@ IMAGE_DEPENDS_ubi = "mtd-utils-native"
> >  IMAGE_DEPENDS_ubifs = "mtd-utils-native"
> >
> >  # This variable is available to request which values are suitable
> for IMAGE_FSTYPES
> > -IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz live squashfs
> squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz
> cpio.lzma"
> > +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz btrfs live
> squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz
> cpio.xz cpio.lzma"
> 
> As Joshua already replied, this isn't enough.
> This raises one question, though. Have you successfully built
> btrfs-image? If so, I assume that you have more patches locally,
> otherwise you should resist submitting patches, unless they're clearly
> marked as RFC (request for comments, and thus not to be applied).
> 
> Cheers,
> Anders

All these pieces Josh mentioned are already in the tree. I found this new line, and saw btrfs was not listed in it so added there also. The btrfs support in yocto is working with Linux-yocto 3.x kernel. The btrfs kernel config needs to be enabled, I have sent a patch for that implementing it as a kernel feature, Once that is there then also need to enable the btrfs feature in the Linux-yocto kernel recipe. I will send a patch for that too. 

Thanks,
Nitin
Anders Darander - Sept. 8, 2011, 7:13 a.m.
* Kamble, Nitin A <nitin.a.kamble@intel.com> [110907 20:28]:
> > -----Original Message----- From:
> > openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> > Of Anders Darander Sent: Wednesday, September 07, 2011 12:16 AM To:
> > openembedded-core@lists.openembedded.org Subject: Re: [OE-core]
> > [PATCH 1/1] image-types: add btrfs as a supported fstype
> > 
> > As Joshua already replied, this isn't enough.  This raises one
> > question, though. Have you successfully built btrfs-image? If so, I
> > assume that you have more patches locally, otherwise you should
> > resist submitting patches, unless they're clearly marked as RFC
> > (request for comments, and thus not to be applied).
> 
> All these pieces Josh mentioned are already in the tree. I found this
> new line, and saw btrfs was not listed in it so added there also. The
> btrfs support in yocto is working with Linux-yocto 3.x kernel. The
> btrfs kernel config needs to be enabled, I have sent a patch for that
> implementing it as a kernel feature, Once that is there then also need
> to enable the btrfs feature in the Linux-yocto kernel recipe. I will
> send a patch for that too. 

My apologies. 
You're correct in that the pieces mentioned by Josh is already in the
tree.

However, the commit log should probably have included something like
"enabling btrfs support for hob", perhaps worded slightly better. 

Cheers,
Anders
Nitin A Kamble - Sept. 9, 2011, 4:03 p.m.
> 
> My apologies.
> You're correct in that the pieces mentioned by Josh is already in the
> tree.
> 
> However, the commit log should probably have included something like
> "enabling btrfs support for hob", perhaps worded slightly better.

Makes sense. I was not aware of that line is there for hob, now I know it, and change the commit log.
Nitin

> 
> Cheers,
> Anders
> 

> --
> Anders Darander
> ChargeStorm AB
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index c24b326..3e303ed 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -141,4 +141,4 @@  IMAGE_DEPENDS_ubi = "mtd-utils-native"
 IMAGE_DEPENDS_ubifs = "mtd-utils-native"
 
 # This variable is available to request which values are suitable for IMAGE_FSTYPES
-IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz live squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"
+IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz btrfs live squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"