diff mbox series

[04/29] conf/distro/no-static-libs: Allow static musl for rust

Message ID 20220805131252.3706794-4-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit 8d0251ec18ec8d7d66a61cca8adcba5ba246cd92
Headers show
Series [01/29] nativesdk: Clear TUNE_FEATURES | expand

Commit Message

Richard Purdie Aug. 5, 2022, 1:12 p.m. UTC
When building rust for musl targets we need the static library from musl,
so enable it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/conf/distro/include/no-static-libs.inc | 2 ++
 1 file changed, 2 insertions(+)

Comments

Khem Raj Aug. 7, 2022, 12:41 a.m. UTC | #1
On Fri, Aug 5, 2022 at 6:13 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> When building rust for musl targets we need the static library from musl,
> so enable it.

it should be ok in general to link with static libs from musl so this
change is fine.

>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/conf/distro/include/no-static-libs.inc | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/conf/distro/include/no-static-libs.inc b/meta/conf/distro/include/no-static-libs.inc
> index ee673834601..75359928a14 100644
> --- a/meta/conf/distro/include/no-static-libs.inc
> +++ b/meta/conf/distro/include/no-static-libs.inc
> @@ -18,6 +18,8 @@ DISABLE_STATIC:pn-nativesdk-openssl = ""
>  DISABLE_STATIC:pn-gcc-runtime = ""
>  # libusb1-native is used to build static dfu-util-native
>  DISABLE_STATIC:pn-libusb1-native = ""
> +# needed by rust
> +DISABLE_STATIC:pn-musl = ""
>
>  EXTRA_OECONF:append = "${DISABLE_STATIC}"
>
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#168938): https://lists.openembedded.org/g/openembedded-core/message/168938
> Mute This Topic: https://lists.openembedded.org/mt/92834379/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/conf/distro/include/no-static-libs.inc b/meta/conf/distro/include/no-static-libs.inc
index ee673834601..75359928a14 100644
--- a/meta/conf/distro/include/no-static-libs.inc
+++ b/meta/conf/distro/include/no-static-libs.inc
@@ -18,6 +18,8 @@  DISABLE_STATIC:pn-nativesdk-openssl = ""
 DISABLE_STATIC:pn-gcc-runtime = ""
 # libusb1-native is used to build static dfu-util-native
 DISABLE_STATIC:pn-libusb1-native = ""
+# needed by rust
+DISABLE_STATIC:pn-musl = ""
 
 EXTRA_OECONF:append = "${DISABLE_STATIC}"