Patchworkβ [oe] lighttpd 1.4.18 runtime issue

login
register
about
Submitter Michael Lippautz
Date 2009-10-06 09:16:03
Message ID <1254820563.6107.4.camel@leeloo.somedomain>
Download mbox | patch
Permalink /patch/1098/
State Applied, archived
Headers show

Comments

Michael Lippautz - 2009-10-06 09:16:03
Am Montag, den 05.10.2009, 19:59 -0300 schrieb Otavio Salvador:
> The best way to provide the patch is to commit it locally and use git
> format-patch to export it. Then send it attached to the mail.

Thx for all the infos. Here's the patch.
Otavio Salvador - 2009-10-08 00:46:05
Hello,

On Tue, Oct 6, 2009 at 6:16 AM, Michael Lippautz
<michael.lippautz@gmail.com> wrote:
> Am Montag, den 05.10.2009, 19:59 -0300 schrieb Otavio Salvador:
>> The best way to provide the patch is to commit it locally and use git
>> format-patch to export it. Then send it attached to the mail.
>
> Thx for all the infos. Here's the patch.

In meanwhile it looks to have been fixed in current master; would be
nice if you could test it and provide a updated patch if still needed.
Michael Lippautz - 2009-10-08 12:17:25
2009/10/8 Otavio Salvador <otavio@ossystems.com.br>:
> In meanwhile it looks to have been fixed in current master; would be
> nice if you could test it and provide a updated patch if still needed.

I actually tested the build today. Unfortunatelly there is still an
issue remaining.
The patch fixed the automatically loaded modules, but missed that
there are still two modules loaded on startup in the config that is
shipped. These modules are module-access and module-accesslog.
(Actually I missed them when I wrote the patch, sorry for that.)

 Since the config states that these modules "should" be loaded, it has
to be decided whether OE goes with this recommendation and adds the
additional two modules as runtime dep., OR just strips/uncomments the
specific sections in the config.

Regards,
Michael
Henning Heinold - 2009-10-08 20:08:32
On Thu, Oct 08, 2009 at 02:17:25PM +0200, Michael Lippautz wrote:
> 2009/10/8 Otavio Salvador <otavio@ossystems.com.br>:
> > In meanwhile it looks to have been fixed in current master; would be
> > nice if you could test it and provide a updated patch if still needed.
> 
> I actually tested the build today. Unfortunatelly there is still an
> issue remaining.
> The patch fixed the automatically loaded modules, but missed that
> there are still two modules loaded on startup in the config that is
> shipped. These modules are module-access and module-accesslog.
> (Actually I missed them when I wrote the patch, sorry for that.)
> 
>  Since the config states that these modules "should" be loaded, it has
> to be decided whether OE goes with this recommendation and adds the
> additional two modules as runtime dep., OR just strips/uncomments the
> specific sections in the config.
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

So what you like? I will do it *g*.

Bye Henning

Patch

From fc5de54141069d3c6ef8a15783563123e1c479d1 Mon Sep 17 00:00:00 2001
From: Michael Lippautz <michael.lippautz@gmail.com>
Date: Tue, 6 Oct 2009 11:04:04 +0200
Subject: [PATCH] lighttpd 1.4.18: Fixed missing runtime module dependencies


Signed-off-by: Michael Lippautz <michael.lippautz@gmail.com>
---
 recipes/lighttpd/lighttpd_1.4.18.bb |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/recipes/lighttpd/lighttpd_1.4.18.bb b/recipes/lighttpd/lighttpd_1.4.18.bb
index d5870ba..a446122 100644
--- a/recipes/lighttpd/lighttpd_1.4.18.bb
+++ b/recipes/lighttpd/lighttpd_1.4.18.bb
@@ -2,7 +2,12 @@  DESCRIPTION = "Web server"
 SECTION = "net"
 LICENSE = "BSD"
 DEPENDS = "libpcre"
-PR = "r3"
+RDEPENDS_${PN} += " \
+        lighttpd-module-indexfile \
+        lighttpd-module-dirlisting \
+        lighttpd-module-staticfile"
+
+PR = "r4"
 
 SRC_URI = "http://www.lighttpd.net/download/lighttpd-${PV}.tar.gz \
 	   file://configure.in.patch;patch=1 \
-- 
1.6.3.3