Patchwork [RESEND] bitbake.conf: fix ubi images creation

login
register
mail settings
Submitter Denis Carikli
Date Sept. 2, 2011, 4:09 p.m.
Message ID <1314979795-13537-1-git-send-email-denis@eukrea.com>
Download mbox | patch
Permalink /patch/10913/
State Accepted
Headers show

Comments

Denis Carikli - Sept. 2, 2011, 4:09 p.m.
Without that commit ubinize.cfg lack a volume name value,
  and the related ubinize.cfg line looks like that:
    vol_name=
  which result in a broken ubi image,which after beeing flashed produce
  the following error:
    UBI error: vtbl_check: volume table check failed: record 0, error 11
  wich result in a kernel panic because the rootfs can't be mounted.

Signed-off-by: Denis Carikli <denis@eukrea.com>
---
 meta/conf/bitbake.conf |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Anders Darander - Sept. 5, 2011, 7:05 a.m.
* Denis Carikli <denis@eukrea.com> [110902 18:19]:
> Without that commit ubinize.cfg lack a volume name value,
>   and the related ubinize.cfg line looks like that:
>     vol_name=
>   which result in a broken ubi image,which after beeing flashed produce
>   the following error:
>     UBI error: vtbl_check: volume table check failed: record 0, error 11
>   wich result in a kernel panic because the rootfs can't be mounted.

I've recently spent some time debugging this very same issue, when
converting an on-going project from oe-dev to oe-core.

> Signed-off-by: Denis Carikli <denis@eukrea.com>

Acked-by: Anders Darander <anders@chargestorm.se>

> ---
>  meta/conf/bitbake.conf |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index a68be07..14ee90c 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -382,6 +382,8 @@ IMAGE_BASENAME = "${PN}"
>  IMAGE_NAME = "${IMAGE_BASENAME}-${MACHINE}-${DATETIME}"
>  IMAGE_LINK_NAME = "${IMAGE_BASENAME}-${MACHINE}"
>  
> +UBI_VOLNAME ?= "${MACHINE}-rootfs"
> +
>  # This option allows for a percentage overage of the actual image size rather than a
>  # fixed extra space, this is space needed for initial startup and basic operations.
>  IMAGE_OVERHEAD_FACTOR ?= 1.3
Martin Jansa - Sept. 5, 2011, 7:09 a.m.
On Mon, Sep 05, 2011 at 09:05:22AM +0200, Anders Darander wrote:
> * Denis Carikli <denis@eukrea.com> [110902 18:19]:
> > Without that commit ubinize.cfg lack a volume name value,
> >   and the related ubinize.cfg line looks like that:
> >     vol_name=
> >   which result in a broken ubi image,which after beeing flashed produce
> >   the following error:
> >     UBI error: vtbl_check: volume table check failed: record 0, error 11
> >   wich result in a kernel panic because the rootfs can't be mounted.
> 
> I've recently spent some time debugging this very same issue, when
> converting an on-going project from oe-dev to oe-core.
> 
> > Signed-off-by: Denis Carikli <denis@eukrea.com>
> 
> Acked-by: Anders Darander <anders@chargestorm.se>

Acked-by: Martin Jansa <Martin.Jansa@gmail.com>
> 
> > ---
> >  meta/conf/bitbake.conf |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index a68be07..14ee90c 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -382,6 +382,8 @@ IMAGE_BASENAME = "${PN}"
> >  IMAGE_NAME = "${IMAGE_BASENAME}-${MACHINE}-${DATETIME}"
> >  IMAGE_LINK_NAME = "${IMAGE_BASENAME}-${MACHINE}"
> >  
> > +UBI_VOLNAME ?= "${MACHINE}-rootfs"
> > +
> >  # This option allows for a percentage overage of the actual image size rather than a
> >  # fixed extra space, this is space needed for initial startup and basic operations.
> >  IMAGE_OVERHEAD_FACTOR ?= 1.3
> -- 
> Anders Darander
> ChargeStorm AB
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
James Limbouris - Sept. 5, 2011, 7:33 a.m.
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Anders Darander
> Sent: Monday, 5 September 2011 3:05 PM
> To: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [RESEND] bitbake.conf: fix ubi images creation
> 
> * Denis Carikli <denis@eukrea.com> [110902 18:19]:
> > Without that commit ubinize.cfg lack a volume name value,
> >   and the related ubinize.cfg line looks like that:
> >     vol_name=
> >   which result in a broken ubi image,which after beeing flashed produce
> >   the following error:
> >     UBI error: vtbl_check: volume table check failed: record 0, error 11
> >   wich result in a kernel panic because the rootfs can't be mounted.
> 
> I've recently spent some time debugging this very same issue, when
> converting an on-going project from oe-dev to oe-core.
> 

Me too!

> > Signed-off-by: Denis Carikli <denis@eukrea.com>
> 
> Acked-by: Anders Darander <anders@chargestorm.se>
> 
> > ---
> >  meta/conf/bitbake.conf |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index a68be07..14ee90c 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -382,6 +382,8 @@ IMAGE_BASENAME = "${PN}"
> >  IMAGE_NAME = "${IMAGE_BASENAME}-${MACHINE}-${DATETIME}"
> >  IMAGE_LINK_NAME = "${IMAGE_BASENAME}-${MACHINE}"
> >
> > +UBI_VOLNAME ?= "${MACHINE}-rootfs"
> > +
> >  # This option allows for a percentage overage of the actual image size rather
> than a
> >  # fixed extra space, this is space needed for initial startup and basic
> operations.
> >  IMAGE_OVERHEAD_FACTOR ?= 1.3
> --
> Anders Darander
> ChargeStorm AB
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Richard Purdie - Sept. 5, 2011, 7:37 p.m.
On Fri, 2011-09-02 at 18:09 +0200, Denis Carikli wrote:
> Without that commit ubinize.cfg lack a volume name value,
>   and the related ubinize.cfg line looks like that:
>     vol_name=
>   which result in a broken ubi image,which after beeing flashed produce
>   the following error:
>     UBI error: vtbl_check: volume table check failed: record 0, error 11
>   wich result in a kernel panic because the rootfs can't be mounted.
> 
> Signed-off-by: Denis Carikli <denis@eukrea.com>
> ---
>  meta/conf/bitbake.conf |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index a68be07..14ee90c 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -382,6 +382,8 @@ IMAGE_BASENAME = "${PN}"
>  IMAGE_NAME = "${IMAGE_BASENAME}-${MACHINE}-${DATETIME}"
>  IMAGE_LINK_NAME = "${IMAGE_BASENAME}-${MACHINE}"
>  
> +UBI_VOLNAME ?= "${MACHINE}-rootfs"
> +
>  # This option allows for a percentage overage of the actual image size rather than a
>  # fixed extra space, this is space needed for initial startup and basic operations.
>  IMAGE_OVERHEAD_FACTOR ?= 1.3

Merged to master but I moved this definition to image_types.bbclass
since thats the only place its used and we may as well not pollute the
global data store when we don't need to.

Cheers,

Richard

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index a68be07..14ee90c 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -382,6 +382,8 @@  IMAGE_BASENAME = "${PN}"
 IMAGE_NAME = "${IMAGE_BASENAME}-${MACHINE}-${DATETIME}"
 IMAGE_LINK_NAME = "${IMAGE_BASENAME}-${MACHINE}"
 
+UBI_VOLNAME ?= "${MACHINE}-rootfs"
+
 # This option allows for a percentage overage of the actual image size rather than a
 # fixed extra space, this is space needed for initial startup and basic operations.
 IMAGE_OVERHEAD_FACTOR ?= 1.3