Patchwork [meta-oe,1/3] bonnie++: Add version 1.03c (initial recipe)

login
register
mail settings
Submitter Noor Ahsan
Date Aug. 30, 2011, 10:58 a.m.
Message ID <ef49be97f8e75115c1b001694f676f52a53a70c6.1314691875.git.noor_ahsan@mentor.com>
Download mbox | patch
Permalink /patch/10759/
State New, archived
Headers show

Comments

Noor Ahsan - Aug. 30, 2011, 10:58 a.m.
From: Noor Ahsan <noor_ahsan@mentor.com>

* Imported from oe.dev commit id 44985d56bc556786812a0a02d6219afd31a7381d.
* Merge .bb and .inc file.

Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
---
 meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb |   30 ++++++++++++++++++++
 .../bonnie/files/gcc-4.3-fixes.patch               |   19 ++++++++++++
 2 files changed, 49 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb
 create mode 100644 meta-oe/recipes-benchmark/bonnie/files/gcc-4.3-fixes.patch
Koen Kooi - Aug. 30, 2011, 11:49 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 30-08-11 12:58, Noor, Ahsan schreef:
> From: Noor Ahsan <noor_ahsan@mentor.com>
> 
> * Imported from oe.dev commit id 44985d56bc556786812a0a02d6219afd31a7381d. * Merge .bb and .inc file.
> 
> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com> --- meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb |   30 ++++++++++++++++++++ .../bonnie/files/gcc-4.3-fixes.patch               |   19 ++++++++++++ 2 files changed, 49 insertions(+), 0 deletions(-) create mode 100644
> meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb create mode 100644 meta-oe/recipes-benchmark/bonnie/files/gcc-4.3-fixes.patch
> 
> diff --git a/meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb b/meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb new file mode 100644 index 0000000..2067307 --- /dev/null +++ b/meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb @@ -0,0 +1,30 @@ +DESCRIPTION = "Tests large file IO and
> creation/deletion of small files." +HOMEPAGE = "http://www.coker.com.au/bonnie++/" +LICENSE = "GPL v2"

without spaces please

> +LIC_FILES_CHKSUM = "file://copyright.txt;md5=cd4dde95a6b9d122f0a9150ae9cc3ee0" + +SRC_URI = "http://www.coker.com.au/bonnie++/bonnie++-${PV}.tgz \ +           file://gcc-4.3-fixes.patch \ +           " +SRC_URI[md5sum] = "77a1ba78f37bdd7f024b67e1e36ad151" +SRC_URI[sha256sum] =
> "c674f1182f4c20f1e6d038feceb0a6617fc3e7658dfbbac89396043b49612a26" + +SCRIPTS = "bon_csv2html bon_csv2txt" +EXES = "bonnie++ zcav"

And move those 2 below the inherit line please.

> + +inherit autotools + +do_install () { +        install -d ${D}/bin +        install -d ${D}/sbin +        install -m 0755 ${EXES} ${D}/sbin +        install -m 0755 ${SCRIPTS} ${D}/bin +} + +PACKAGES += "bonnie-scripts" + +FILES_${PN} = "/sbin" +FILES_bonnie-scripts="/bin" + +TARGET_CC_ARCH
> += "${LDFLAGS}"

and move this one above do_install please. The general idea is to group them by usage and TARGET_CC_ARCH is a configure/compile thing.


regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOXM5GMkyGM64RGpERAsl1AKClQMALBYl1u1e67wpOM9+Sp3L1rgCeN/tw
jieEZYOfqBAgQFkgDaqmfko=
=mlKS
-----END PGP SIGNATURE-----
Noor Ahsan - Aug. 30, 2011, 12:29 p.m.
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf
Of
> Koen Kooi
> Sent: Tuesday, August 30, 2011 4:49 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe][PATCH 1/3] bonnie++: Add version 1.03c
> (initial recipe)
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Op 30-08-11 12:58, Noor, Ahsan schreef:
> > From: Noor Ahsan <noor_ahsan@mentor.com>
> >
> > * Imported from oe.dev commit id
> 44985d56bc556786812a0a02d6219afd31a7381d. * Merge .bb and .inc file.
> >
> > Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com> --- meta-
> oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb |   30
> ++++++++++++++++++++ .../bonnie/files/gcc-4.3-fixes.patch
> |   19 ++++++++++++ 2 files changed, 49 insertions(+), 0 deletions(-)
> create mode 100644
> > meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb create mode
100644
> meta-oe/recipes-benchmark/bonnie/files/gcc-4.3-fixes.patch
> >
> > diff --git a/meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb
> b/meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb new file mode
> 100644 index 0000000..2067307 --- /dev/null +++ b/meta-oe/recipes-
> benchmark/bonnie/bonnie++_1.03c.bb @@ -0,0 +1,30 @@ +DESCRIPTION =
> "Tests large file IO and
> > creation/deletion of small files." +HOMEPAGE =
> "http://www.coker.com.au/bonnie++/" +LICENSE = "GPL v2"
> 
> without spaces please
> 
> > +LIC_FILES_CHKSUM =
> "file://copyright.txt;md5=cd4dde95a6b9d122f0a9150ae9cc3ee0" + +SRC_URI
> = "http://www.coker.com.au/bonnie++/bonnie++-${PV}.tgz \ +
> file://gcc-4.3-fixes.patch \ +           " +SRC_URI[md5sum] =
> "77a1ba78f37bdd7f024b67e1e36ad151" +SRC_URI[sha256sum] =
> > "c674f1182f4c20f1e6d038feceb0a6617fc3e7658dfbbac89396043b49612a26" +
> +SCRIPTS = "bon_csv2html bon_csv2txt" +EXES = "bonnie++ zcav"
> 
> And move those 2 below the inherit line please.
> 
> > + +inherit autotools + +do_install () { +        install -d ${D}/bin
> +        install -d ${D}/sbin +        install -m 0755 ${EXES}
> ${D}/sbin +        install -m 0755 ${SCRIPTS} ${D}/bin +} + +PACKAGES
> += "bonnie-scripts" + +FILES_${PN} = "/sbin" +FILES_bonnie-
> scripts="/bin" + +TARGET_CC_ARCH
> > += "${LDFLAGS}"
> 
> and move this one above do_install please. The general idea is to
group
> them by usage and TARGET_CC_ARCH is a configure/compile thing.
> 
> 
> regards,
> 
> Koen


Hi,

The recipe is verified on oe-styliz.py script and the formatting is done
by that script. Your recommendations are conflicting with oe-stylize.
Kindly update oe-stylize according to your recommendation so that it
give output according to your expectations.

Thanks.

Regards,
Noor

Patch

diff --git a/meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb b/meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb
new file mode 100644
index 0000000..2067307
--- /dev/null
+++ b/meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb
@@ -0,0 +1,30 @@ 
+DESCRIPTION = "Tests large file IO and creation/deletion of small files."
+HOMEPAGE = "http://www.coker.com.au/bonnie++/"
+LICENSE = "GPL v2"
+LIC_FILES_CHKSUM = "file://copyright.txt;md5=cd4dde95a6b9d122f0a9150ae9cc3ee0"
+
+SRC_URI = "http://www.coker.com.au/bonnie++/bonnie++-${PV}.tgz \
+           file://gcc-4.3-fixes.patch \
+           "
+SRC_URI[md5sum] = "77a1ba78f37bdd7f024b67e1e36ad151"
+SRC_URI[sha256sum] = "c674f1182f4c20f1e6d038feceb0a6617fc3e7658dfbbac89396043b49612a26"
+
+SCRIPTS = "bon_csv2html bon_csv2txt"
+EXES = "bonnie++ zcav"
+
+inherit autotools
+
+do_install () {
+        install -d ${D}/bin
+        install -d ${D}/sbin
+        install -m 0755 ${EXES} ${D}/sbin
+        install -m 0755 ${SCRIPTS} ${D}/bin
+}
+
+PACKAGES += "bonnie-scripts"
+
+FILES_${PN} = "/sbin"
+FILES_bonnie-scripts="/bin"
+
+TARGET_CC_ARCH += "${LDFLAGS}"
+
diff --git a/meta-oe/recipes-benchmark/bonnie/files/gcc-4.3-fixes.patch b/meta-oe/recipes-benchmark/bonnie/files/gcc-4.3-fixes.patch
new file mode 100644
index 0000000..67f1b74
--- /dev/null
+++ b/meta-oe/recipes-benchmark/bonnie/files/gcc-4.3-fixes.patch
@@ -0,0 +1,19 @@ 
+Includes string.h to one of the source file.
+
+Upstream-Status: Inappropriate [not author.]
+---
+ zcav.cpp |    1 +
+ 1 file changed, 1 insertion(+)
+
+Index: bonnie++-1.03a/zcav.cpp
+===================================================================
+--- bonnie++-1.03a.orig/zcav.cpp
++++ bonnie++-1.03a/zcav.cpp
+@@ -15,6 +15,7 @@ using namespace std;
+ #else
+ #include <vector.h>
+ #endif
++#include <string.h>
+ 
+ // Read the specified number of megabytes of data from the fd and return the
+ // amount of time elapsed in seconds.