Patchwork [2/2] tcl: fix networking breakage

login
register
mail settings
Submitter Koen Kooi
Date Aug. 24, 2011, 6:32 p.m.
Message ID <1314210721-29941-2-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/10499/
State New, archived
Headers show

Comments

Koen Kooi - Aug. 24, 2011, 6:32 p.m.
Without providing these site entries tcl networking doesn't work on the target.

Original OE commit:

commit 0c340037644f87054462f62b50cd397c162615b7
Author: Koen Kooi <koen@openembedded.org>
Date:   Wed May 26 13:04:18 2010 +0200

    tcl: add 2 entries to arm-linux site file (possibly only glibc specific, need to check)

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/recipes-devtools/tcltk/tcl_8.5.9.bb |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
Saul Wold - Aug. 24, 2011, 6:36 p.m.
On 08/24/2011 11:32 AM, Koen Kooi wrote:
> Without providing these site entries tcl networking doesn't work on the target.
>
> Original OE commit:
>
> commit 0c340037644f87054462f62b50cd397c162615b7
> Author: Koen Kooi<koen@openembedded.org>
> Date:   Wed May 26 13:04:18 2010 +0200
>
>      tcl: add 2 entries to arm-linux site file (possibly only glibc specific, need to check)
>
> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
> ---
>   meta/recipes-devtools/tcltk/tcl_8.5.9.bb |    6 ++++--
>   1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
> index 2eabb4d..1b4ae83 100644
> --- a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
> +++ b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://../license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11
>       file://../win/license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11 \
>       "
>
> -PR = "r1"
> +PR = "r2"
>
>   BASE_SRC_URI = "${SOURCEFORGE_MIRROR}/tcl/tcl${PV}-src.tar.gz \
>                   file://tcl-add-soname.patch"
> @@ -30,7 +30,9 @@ inherit autotools
>
>   DEPENDS_virtclass-native = ""
>
> -EXTRA_OECONF = "--enable-threads"
> +EXTRA_OECONF = "--enable-threads \
> +                tcl_cv_api_getaddrinfo=yes \
> +               "
>
Koen,

This was asked last time you submitted this, what's the reasoning for 
adding it here vs in a site files?

Sau!


>   do_configure() {
>   	gnu-configize
Koen Kooi - Aug. 24, 2011, 7:45 p.m.
Op 24 aug. 2011 om 20:36 heeft Saul Wold <sgw@linux.intel.com> het volgende geschreven:

> On 08/24/2011 11:32 AM, Koen Kooi wrote:
>> Without providing these site entries tcl networking doesn't work on the target.
>> 
>> Original OE commit:
>> 
>> commit 0c340037644f87054462f62b50cd397c162615b7
>> Author: Koen Kooi<koen@openembedded.org>
>> Date:   Wed May 26 13:04:18 2010 +0200
>> 
>>     tcl: add 2 entries to arm-linux site file (possibly only glibc specific, need to check)
>> 
>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
>> ---
>>  meta/recipes-devtools/tcltk/tcl_8.5.9.bb |    6 ++++--
>>  1 files changed, 4 insertions(+), 2 deletions(-)
>> 
>> diff --git a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
>> index 2eabb4d..1b4ae83 100644
>> --- a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
>> +++ b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
>> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://../license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11
>>      file://../win/license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11 \
>>      "
>> 
>> -PR = "r1"
>> +PR = "r2"
>> 
>>  BASE_SRC_URI = "${SOURCEFORGE_MIRROR}/tcl/tcl${PV}-src.tar.gz \
>>                  file://tcl-add-soname.patch"
>> @@ -30,7 +30,9 @@ inherit autotools
>> 
>>  DEPENDS_virtclass-native = ""
>> 
>> -EXTRA_OECONF = "--enable-threads"
>> +EXTRA_OECONF = "--enable-threads \
>> +                tcl_cv_api_getaddrinfo=yes \
>> +               "
>> 
> Koen,
> 
> This was asked last time you submitted this, what's the reasoning for adding it here vs in a site files?

Just minicing the original commit, I have no objection to putting it in a site file


> 
> Sau!
> 
> 
>>  do_configure() {
>>      gnu-configize

Patch

diff --git a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
index 2eabb4d..1b4ae83 100644
--- a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
+++ b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
@@ -11,7 +11,7 @@  LIC_FILES_CHKSUM = "file://../license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11
     file://../win/license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11 \
     "
 
-PR = "r1"
+PR = "r2"
 
 BASE_SRC_URI = "${SOURCEFORGE_MIRROR}/tcl/tcl${PV}-src.tar.gz \
                 file://tcl-add-soname.patch"
@@ -30,7 +30,9 @@  inherit autotools
 
 DEPENDS_virtclass-native = ""
 
-EXTRA_OECONF = "--enable-threads"
+EXTRA_OECONF = "--enable-threads \
+                tcl_cv_api_getaddrinfo=yes \
+               "
 
 do_configure() {
 	gnu-configize