| Submitter | Ihar Hrachyshka |
|---|---|
| Date | 2009-09-07 13:10:16 |
| Message ID | <1252329016-10848-4-git-send-email-ihar.hrachyshka@gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/1046/ |
| State | New |
| Headers | show |
Comments
On Mon, 2009-09-07 at 16:10 +0300, Ihar Hrachyshka wrote:
> +NEED_UNZIP_FOR_UNPACK=1
Why is this better than just declaring an explicit dependency of
do_unpack on unzip-native? It's not obvious to me that the extra level
of abstraction buys much in this situation.
p.
On Wed, Sep 09, 2009 at 02:05:27PM +0100, Phil Blundell wrote: > On Mon, 2009-09-07 at 16:10 +0300, Ihar Hrachyshka wrote: > > +NEED_UNZIP_FOR_UNPACK=1 > > Why is this better than just declaring an explicit dependency of > do_unpack on unzip-native? It's not obvious to me that the extra level > of abstraction buys much in this situation. > > p. > We can drob the variable then. What about .zip extension auto detection?
Patch
diff --git a/recipes/misc-binary-only/tda1004x-firmware.bb b/recipes/misc-binary-only/tda1004x-firmware.bb index 1e4d685..ff60717 100644 --- a/recipes/misc-binary-only/tda1004x-firmware.bb +++ b/recipes/misc-binary-only/tda1004x-firmware.bb @@ -1,9 +1,10 @@ SECTION = "base" -DEPENDS = "unzip-native" SRC_URI = "http://hauppauge.lightpath.net/de/nova-pci218c.exe" FILES_${PN} = '*' +NEED_UNZIP_FOR_UNPACK=1 + python do_unpack() { import re diff --git a/recipes/mozilla/firefox-l10n.inc b/recipes/mozilla/firefox-l10n.inc index 31555e3..cecd53a 100644 --- a/recipes/mozilla/firefox-l10n.inc +++ b/recipes/mozilla/firefox-l10n.inc @@ -11,13 +11,14 @@ def get_language_name(package): return lang -DEPENDS = "unzip-native" RDEPENDS = "firefox" LANGUAGE = "${@get_language_name('${PN}')}" SRC_URI = "http://releases.mozilla.org/pub/mozilla.org/firefox/releases/${PV}/linux-i686/xpi/${LANGUAGE}.xpi" S = "${WORKDIR}" +NEED_UNZIP_FOR_UNPACK=1 + do_configure() { unzip -o -q -d ${LANGUAGE} ${LANGUAGE}.xpi }
Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com> --- recipes/misc-binary-only/tda1004x-firmware.bb | 3 ++- recipes/mozilla/firefox-l10n.inc | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)