Patchwork [2/8] kernel.bbclass: blacklist perf-dbg

login
register
mail settings
Submitter Otavio Salvador
Date Aug. 20, 2011, 4:58 a.m.
Message ID <7dc65a7b7090c2504783307152ec3ab6e5376e53.1313816148.git.otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/10317/
State New, archived
Headers show

Comments

Otavio Salvador - Aug. 20, 2011, 4:58 a.m.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 meta/classes/kernel.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Saul Wold - Aug. 22, 2011, 6:29 p.m.
On 08/19/2011 09:58 PM, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador<otavio@ossystems.com.br>
> ---
>   meta/classes/kernel.bbclass |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index a2b10f2..ff3fa46 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -440,7 +440,7 @@ python populate_packages_prepend () {
>   	metapkg = "kernel-modules"
>   	bb.data.setVar('ALLOW_EMPTY_' + metapkg, "1", d)
>   	bb.data.setVar('FILES_' + metapkg, "", d)
> -	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux', 'perf', 'kernel-misc' ]
> +	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux', 'perf', 'perf-dbg', 'kernel-misc' ]
>   	for l in module_deps.values():
>   		for i in l:
>   			pkg = module_pattern % legitimize_package_name(re.match(module_regex, os.path.basename(i)).group(1))

A possible better question is why perf-dbg is getting generated and 
what's in it?

BTW, as noted elsewhere, it would be good to add additional comments as 
to why you are doing some of the changes.

Thanks
	Sau!
Otavio Salvador - Aug. 22, 2011, 6:53 p.m.
On Mon, Aug 22, 2011 at 15:29, Saul Wold <sgw@linux.intel.com> wrote:
> A possible better question is why perf-dbg is getting generated and what's
> in it?

I am sorry but I don't know the answer for it.

> BTW, as noted elsewhere, it would be good to add additional comments as to
> why you are doing some of the changes.

Reducing the delta between meta-oe and oe-core classes; that's why I
did this change.

Patch

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index a2b10f2..ff3fa46 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -440,7 +440,7 @@  python populate_packages_prepend () {
 	metapkg = "kernel-modules"
 	bb.data.setVar('ALLOW_EMPTY_' + metapkg, "1", d)
 	bb.data.setVar('FILES_' + metapkg, "", d)
-	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux', 'perf', 'kernel-misc' ]
+	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux', 'perf', 'perf-dbg', 'kernel-misc' ]
 	for l in module_deps.values():
 		for i in l:
 			pkg = module_pattern % legitimize_package_name(re.match(module_regex, os.path.basename(i)).group(1))