Patchwork [CONSOLIDATED,PULL,05/32] tcl: fix networking breakage

login
register
mail settings
Submitter Saul Wold
Date Aug. 18, 2011, 8:55 p.m.
Message ID <811a2cc3d1f9d025f99f7decfa6d3603cb3ca5f2.1313700595.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/10199/
State New, archived
Headers show

Comments

Saul Wold - Aug. 18, 2011, 8:55 p.m.
From: Koen Kooi <koen@dominion.thruhere.net>

Without providing these site entries tcl networking doesn't work on the target.

Original OE commit:

commit 0c340037644f87054462f62b50cd397c162615b7
Author: Koen Kooi <koen@openembedded.org>
Date:   Wed May 26 13:04:18 2010 +0200

    tcl: add 2 entries to arm-linux site file (possibly only glibc specific, need to check)

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/recipes-devtools/tcltk/tcl_8.5.9.bb |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
Richard Purdie - Aug. 19, 2011, 2:31 p.m.
On Thu, 2011-08-18 at 13:55 -0700, Saul Wold wrote:
> From: Koen Kooi <koen@dominion.thruhere.net>
> 
> Without providing these site entries tcl networking doesn't work on the target.
> 
> Original OE commit:
> 
> commit 0c340037644f87054462f62b50cd397c162615b7
> Author: Koen Kooi <koen@openembedded.org>
> Date:   Wed May 26 13:04:18 2010 +0200
> 
>     tcl: add 2 entries to arm-linux site file (possibly only glibc specific, need to check)
> 
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta/recipes-devtools/tcltk/tcl_8.5.9.bb |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
> index 2eabb4d..1b4ae83 100644
> --- a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
> +++ b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://../license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11
>      file://../win/license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11 \
>      "
>  
> -PR = "r1"
> +PR = "r2"
>  
>  BASE_SRC_URI = "${SOURCEFORGE_MIRROR}/tcl/tcl${PV}-src.tar.gz \
>                  file://tcl-add-soname.patch"
> @@ -30,7 +30,9 @@ inherit autotools
>  
>  DEPENDS_virtclass-native = ""
>  
> -EXTRA_OECONF = "--enable-threads"
> +EXTRA_OECONF = "--enable-threads \
> +                tcl_cv_api_getaddrinfo=yes \
> +               "
>  

Why are we adding these in the recipe rather than the site files? I can
see the reasons why we might but it does seem to be a change in
behaviour/policy?

Cheers,

Richard

Patch

diff --git a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
index 2eabb4d..1b4ae83 100644
--- a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
+++ b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
@@ -11,7 +11,7 @@  LIC_FILES_CHKSUM = "file://../license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11
     file://../win/license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11 \
     "
 
-PR = "r1"
+PR = "r2"
 
 BASE_SRC_URI = "${SOURCEFORGE_MIRROR}/tcl/tcl${PV}-src.tar.gz \
                 file://tcl-add-soname.patch"
@@ -30,7 +30,9 @@  inherit autotools
 
 DEPENDS_virtclass-native = ""
 
-EXTRA_OECONF = "--enable-threads"
+EXTRA_OECONF = "--enable-threads \
+                tcl_cv_api_getaddrinfo=yes \
+               "
 
 do_configure() {
 	gnu-configize